Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return value error. #320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return value error. #320

wants to merge 1 commit into from

Conversation

BeneficialCode
Copy link

If the CredUnPackAuthenticationBuffer fails, the return value should reflect that, but it must be an HRESULT. We should convert a Windows error code to an HRESULT.

@BeneficialCode
Copy link
Author

@microsoft-github-policy-service agree

zhuman
zhuman approved these changes Aug 23, 2024
View reviewed changes
Copy link

@zhuman zhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuman zhuman zhuman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeneficialCode @zhuman